.text() ignores script and style tags

cheeriojs · May 6, 2017 · 71ec6bb · 71ec6bb
1 parent 4aeae2a
commit 71ec6bb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/lib/static.js b/lib/static.js
@@ -119,8 +119,8 @@ exports.text = function(elems) {
 
   for (var i = 0; i < len; i++) {
     elem = elems[i];
-    if (elem.type === 'text' && elem.tagName != 'script' && elem.tagName != 'style') ret += elem.data;
-    else if (elem.children && elem.type !== 'comment' && elem.tagName != 'script' && elem.tagName != 'style') {
+    if (elem.type === 'text') ret += elem.data;
+    else if (elem.children && elem.type !== 'comment' && elem.tagName !== 'script' && elem.tagName !== 'style') {
       ret += exports.text(elem.children);
     }
   }

diff --git a/test/api/utils.js b/test/api/utils.js
@@ -66,6 +66,11 @@ describe('cheerio', function() {
        expect($.text()).to.equal('');
     });
 
+     it('(cheerio object) : should include text contents of children omiting style and script tags', function(){
+       var $ = cheerio.load('<body>Welcome <div>Hello, testing text function,<script>console.log("hello")</script></div><style type="text/css">.cf-hidden { display: none; }</style>End of messege</body>');
+       expect($.text()).to.equal('Welcome Hello, testing text function,End of messege');
+    });
+
   });