fix(traversing): Make closest be able to start from text nodes (#2811)

Fixes #2810
cheeriojs · Dec 12, 2022 · 97f3739 · 97f3739
1 parent d4e6ae5
commit 97f3739
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/api/traversing.spec.ts b/src/api/traversing.spec.ts
@@ -798,6 +798,12 @@ describe('$(...)', () => {
       const result = $('.saladbar', food).closest('ul');
       expect(result).toHaveLength(0);
     });
+
+    it('(selector) : should find closest element for text nodes', () => {
+      const textNode = $('.apple', food).contents().first();
+      const result = textNode.closest('#food') as Cheerio<Element>;
+      expect(result[0].attribs).toHaveProperty('id', 'food');
+    });
   });
 
   describe('.each', () => {

diff --git a/src/api/traversing.ts b/src/api/traversing.ts
@@ -327,6 +327,9 @@ export function closest<T extends AnyNode>(
       : getFilterFn(selector);
 
   domEach(this, (elem: AnyNode | null) => {
+    if (elem && !isDocument(elem) && !isTag(elem)) {
+      elem = elem.parent;
+    }
     while (elem && isTag(elem)) {
       if (selectFn(elem, 0)) {
         // Do not add duplicate elements to the set