Throw a useful error on invalid input to cheerio.load() (#1087)

cheeriojs · Sep 9, 2020 · ea7c0bc · ea7c0bc
1 parent 3229723
commit ea7c0bc
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/lib/static.js b/lib/static.js
@@ -17,6 +17,10 @@ var serialize = require('dom-serializer'),
  */
 
 exports.load = function(content, options, isDocument) {
+  if (content === null || content === undefined) {
+    throw new Error('cheerio.load() expects a string');
+  }
+
   var Cheerio = require('./cheerio');
 
   options = _.defaults(flattenOptions(options || {}), defaultOptions);

diff --git a/test/api/traversing.js b/test/api/traversing.js
@@ -13,6 +13,17 @@ describe('$(...)', function() {
     $ = cheerio.load(fruits);
   });
 
+  describe('.load', function() {
+    it('should throw a TypeError if given invalid input', function() {
+      expect(function() {
+        cheerio.load();
+      }).to.throwException(function(err) {
+        expect(err).to.be.an(Error);
+        expect(err.message).to.be('cheerio.load() expects a string');
+      });
+    });
+  });
+
   describe('.find', function() {
 
     it('() : should find nothing', function() {