This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
[SPOOL-403] Do not crash when we receive an unexpected error from pushy_common #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Good to merge once we update the pushy_common dep. |
marcparadise
force-pushed
the
SPOOL-403/configurable-body-size
branch
from
14dd31f to
ee9fa28
Compare
When pushy_messaging:parse_message returned an error tuple for reasons other than signature or timestamp (such as message too large) it would crash with a badmatch. This change accepts the error and allows the FSM to continue processing further messages. Signed-off-by: Marc Paradise <[email protected]>
marcparadise
force-pushed
the
SPOOL-403/configurable-body-size
branch
from
ee9fa28 to
450be59
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds handling for other validation errors that can come out of
pushy_messaging:parse_messages.I will be dropping the temporary commit that updates the pushy_common branch once pushy_common#23 merges. Left it unDCO'd so that I wouldn't forget.