This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Remove typhoeus from oc-pushy-pedant #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhass
previously requested changes
Nov 18, 2016
|
@rhass Ah, forgot to move that class. I believe that the tests are only really using EventStreamOld and EventStream isn't instantiated anywhere. If we'd prefer to keep the "EventStream" class then we'll need to re-add curl. |
typhoeus depends on libcurl at runtime. We would like to remove curl from the build. It appears that typhoeus is actually unused in the code so we can drop this dependency. The EventStream class that uses Typhoeus was dead code. This class has been removed and the EventStreamOld class has been renamed to EventStream. Signed-off-by: Steven Danna <[email protected]>
stevendanna
force-pushed
the
ssd/no-libcurl
branch
from
49224e0 to
e6bc474
Compare
Signed-off-by: Steven Danna <[email protected]>
ksubrama
approved these changes
Nov 18, 2016
|
A lot of our curl based code seems to be old code to avoid the SSL cert issue we ran into with Ruby 2 years ago. Those are no longer an issue with a modern ruby and our omnibus builds. So +1 on dropping that class. |
smith
dismissed
rhass’s stale review
Changes have been made to address this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typhoeus depends on libcurl at runtime. We would like to remove curl
from the build. It appears that typhoeus is actually unused in the code
so we can drop this dependency.
Signed-off-by: Steven Danna [email protected]