Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI-272 Mini Donut Charts EAS Table Signed-off-by: Tara Black <ttblack… #394

Merged
merged 1 commit into from
May 31, 2019

Conversation

tarablack01
Copy link
Contributor

…@chef.io>

🔩 Description

Add a mini donut chart to each table row to visualize the service instance health status in the group.

Screen Shot 2019-05-20 at 5 57 19 PM

👍 Definition of Done

Reuse the existing chef-radial-chart with only one circle
Make the size to match with what’s shown in the mockup, 48 * 48px area for each mini donut.
Depending on the effort it takes, the donut chart can be either interactive or non-interactive.
Colors: chef-critical for critical services count, #FF9654 (new color to be added to the palette) for warning services count; #3DA5FF (new color to be added to the palette) for OK services count; #B7BCBC (new color to be added to the palette) for unknown services count.
Link to the extended color palette, related cards: #309, #275

⛓️ Related Resources

https://chefio.atlassian.net/browse/A2-792
https://chef.invisionapp.com/share/PZQMKLHYC8B#/348323823_Slice_1-1

✅ Checklist

  • Necessary tests added/updated?
  • [ x] Code actually executed?
  • [x ] Vetting performed (unit tests, lint, etc.)?

Copy link
Contributor

@susanev susanev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Copy link

@apriofrost apriofrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@vjeffrey vjeffrey merged commit b15737f into master May 31, 2019
@chef-ci chef-ci deleted the UI-272-mini-donut-chart-eas-table branch May 31, 2019 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants