Add proper IAMv2p1 machines to deployment farm #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msorens
added
the
iamv2
srenatus
approved these changes
May 22, 2019
bcmdarroch
approved these changes
May 28, 2019
tduffield
reviewed
May 28, 2019
| vpc = "${var.environment}" | ||
| platform = "ubuntu-16.04" | ||
| key_name = "cd-infrastructure" | ||
| instance_type = "m4.large" |
There was a problem hiding this comment.
Is there a reason this is a m4.large while the other is a m5.large?
There was a problem hiding this comment.
Yes: because somebody started it that way. 😁
If you look at all the other "fresh-install / implace-upgrade" pairs, the fresh install uses m5 and the inplace-upgrade uses m4.
(I personally have no context what those values actually do or mean, though.)
There was a problem hiding this comment.
We should move to m5 large. We don't need to backfill now since that would recreate the instance, but going forward we should use m5 class instances.
Signed-off-by: michael sorens <[email protected]>
Signed-off-by: michael sorens <[email protected]>
Signed-off-by: michael sorens <[email protected]>
msorens
force-pushed
the
ms/add-proper-iamv2p1-machines
branch
from
7499133 to
1e29e10
Compare
tduffield
approved these changes
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description
Previously I had repurposed the IAM v2 "fresh install" machine in the deployment farm to 2.1 (leaving the "inplace upgrade" at v2). But that "conservation of resources" led to more confusion than savings, so this PR reverts the change on the IAM v2 "fresh install" machine and creates first-class siblings for v2.1, both fresh install and inplace upgrade.
👍 Definition of Done
New v2p1 machines are provisioned on each of the dev and acceptance dashboards.
👟 Demo Script / Repro Steps
⛓️ Related Resources
✅ Checklist