Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session Timeout feature in Chef Automate #5627

Merged
merged 6 commits into from
Sep 2, 2021
Merged

Conversation

dishanktiwari2501
Copy link
Collaborator

Signed-off-by: Dishank Tiwari [email protected]

🔩 Description: What code changed, and why?

  • Automate UI checks for user activities such as mouse movement, click, keyboard keypress, scroll, etc.
  • If there is no activity from the user's side for the time specified for idle_timeout_minutes in config.toml then the user will be
    explicitly logged out.
  • This feature can be enabled/disabled by enable_idle_timeout this property in config.toml

⛓️ Related Resources

👍 Definition of Done

Added a new page named Session Timeout under Configure section of Chef Automate.

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

@dishanktiwari2501 dishanktiwari2501 added the documentation Anything related to the Automate docs. label Aug 30, 2021
@dishanktiwari2501 dishanktiwari2501 requested a review from a team as a code owner August 30, 2021 11:30
@netlify
Copy link

netlify bot commented Aug 30, 2021

✔️ Deploy Preview for chef-automate ready!

🔨 Explore the source changes: 9b801a3

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/612fadc28daee400ddfaf2dc

😎 Browse the preview: https://deploy-preview-5627--chef-automate.netlify.app

@kalroy kalroy requested a review from iamazzeez September 1, 2021 08:09
Copy link
Contributor

@iamazzeez iamazzeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also mention a point stating minimum time for idle_timeout_minutes should be 5 minutes or above.

Copy link
Collaborator

@kalroy kalroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While testing I found this error:

Start building sites …
hugo v0.87.0+extended darwin/amd64 BuildDate=unknown
Error: Error building site: "/Users/karoy/Projects/automate/components/docs-chef-io/content/automate/chef_infra_server.md:166:112": failed to extract shortcode: template for shortcode "fontawesome" not found
Built in 966 ms
make: *** [serve] Error 255

I can see this error in netlify too.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kalroy kalroy merged commit 75cfb86 into main Sep 2, 2021
@kalroy kalroy deleted the dt_session-timer-customization branch September 2, 2021 07:04
vivek-yadav pushed a commit that referenced this pull request Sep 7, 2021
* create a new page for the session timeout feature in chef automate

Signed-off-by: Dishank Tiwari <[email protected]>

* A few active language tweaks

Signed-off-by: kagarmoe <[email protected]>

* property values update

Signed-off-by: Dishank Tiwari <[email protected]>

Co-authored-by: kagarmoe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acceptance: verified documentation Anything related to the Automate docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants