New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chef rotate all keys -- rotates a deleted key #257

Closed

stevendanna opened this issue Feb 13, 2017 · 0 comments · Fixed by #351

Assignees

stevendanna commented Feb 13, 2017

From chef/chef-server#1079:

So if '_keys' is anywhere in the name of the vault item, the rotate vault keys command will dismiss the rest of the vault item name and attempt to rotate a key on an invalid name...
Example :
Test_keystore - is read as - Testtore_keys_keys.
And
Test_keystore2 - is read as - Testtore2_keys_keys.

It wasn't attempting to read a deleted vault item, it just seems to escape the string as soon as '_keys' is read.

I haven't been able to look into this more deeply but it smells like an unanchored regular expression somewhere.

stevendanna mentioned this issue

Chef rotate all keys -- rotates a deleted key chef/chef-server#1079

Closed

sanga1794 self-assigned this

sanga1794 mentioned this issue

Replaced string with regex in sub method #351

Merged

10 tasks

tas50 closed this as completed in #351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment