Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced string with regex in sub method #351

Conversation

sanga1794
Copy link
Contributor

@sanga1794 sanga1794 commented Jun 11, 2020

Signed-off-by: sanga17 [email protected]

Description

Fixed knife rotate all keys -- rotates a deleted key

Related Issue

Fixed: #257

Output Before Fix

bundle exec knife vault rotate all keys -c ../../chef-repo/.chef/knife.rb

Rotating keys for: pass user_keys_details_keys
ERROR: ChefVault::Exceptions::KeysNotFound: pass/user_details_keys_keys could not be found

Output After Fix

bundle exec knife vault rotate all keys -c ../../chef-repo/.chef/knife.rb

Rotating keys for: pass user_keys_details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@sanga1794 sanga1794 requested a review from a team June 11, 2020 13:08
@sanga1794 sanga1794 changed the title WIP: Replaced string with regex in sub method Replaced string with regex in sub method Jun 12, 2020
@tas50 tas50 merged commit 46c7221 into chef:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chef rotate all keys -- rotates a deleted key
2 participants