Feature - knife vault update - update item_keys only when no value is provided #202
+46
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 3, 2016 17:18
According to https://github.com/cucumber/cucumber/wiki/Given-When-Then, renamed some steps name to have a better 'purpose' meaning.
Currently, 'knife vault update' does/allows 2 types of operations:
* Updating the VALUES of a vault item;
* 'Updating' (add only) clients/admins of a vault item;
If we don't provide a new VALUE to the 'vault update' command, the
encrypted_data and the 'iv' should not change but only the side data
bag ${item}_keys, which contains the clients/admins node_name and keys.
* If no VALUE provided
|
@thommay any thoughts regarding this PR ?
|
|
@xakraz looks fine, just haven't had chance to review and test it yet. |
|
Ok, thanks @thommay :) |
thommay
added a commit
that referenced
this pull request
Mar 17, 2016
Feature - knife vault update - update item_keys only when no value is provided
|
Thanks for the submission, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
knife vault updatesubcommand does 2 thingssearch-query, or Admins)Or both in the same command
However, it saves the whole
vault_itemobjects (${item}and${item_keys}data bag items) even if only clients or admins are provided (${item_keys}).This PR goes along e87c70c and issue : #193
It is needed when your source of truth is your VCS, and you update your Chef-server via files sync.