[CHEF-18291] Fix the kitchen failures on windows #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashique Saidalavi <[email protected]>
Signed-off-by: Ashique Saidalavi <[email protected]>
|
|
||
| tar_io.rewind | ||
|
|
||
| Docker::Image.build_from_tar(tar_io) |
There was a problem hiding this comment.
What will be the size of tar_io? Everything is handled in memory. As tar_io is a StringIO, it may lead to high memory usage if memory is low in the system
There was a problem hiding this comment.
The tar will contain only the Dockerfile and the authorized_keys file. 3584 is the length of the tar_io string created here.
sanjain-progress
approved these changes
Jan 22, 2025
nikhil2611
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The kitchen was failing when the kitchen-dokken was running on the windows machine where the docker host is remote. This PR fixes the issues with the kitchen-dokken driver on windows.
Related Issue
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.