Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on Plan 9 #163

Merged
merged 1 commit into from
Aug 6, 2020
Merged

Fix build on Plan 9 #163

merged 1 commit into from
Aug 6, 2020

Conversation

fhs
Copy link
Contributor

@fhs fhs commented Jul 31, 2020

The kbdfs(8) man page (http://man.cat-v.org/9front/8/kbdfs)
documents how raw mode works on Plan 9:

If the string rawon has been written to the consctl file and
the file is still open, cons is in raw mode: characters are
not echoed as they are typed, backspace, ^U,' ^W' and `^D'
are not treated specially, and characters are available to
read as soon as they are typed. Ordinary mode is reentered
when rawoff is written to consctl or this file is closed.

These dependencies needed to be updated to fix Plan 9 build:

  • github.com/fatih/color
  • github.com/mattn/go-isatty

The kbdfs(8) man page (http://man.cat-v.org/9front/8/kbdfs)
documents how raw mode works on Plan 9:

  If the string rawon has been written to the consctl file and
  the file is still open, cons is in raw mode: characters are
  not echoed as they are typed, backspace, `^U,' `^W' and `^D'
  are not treated specially, and characters are available to
  read as soon as they are typed.  Ordinary mode is reentered
  when rawoff is written to consctl or this file is closed.

These dependencies needed to be updated to fix Plan 9 build:

  - github.com/fatih/color
  - github.com/mattn/go-isatty
@fhs fhs mentioned this pull request Aug 5, 2020
5 tasks
@cheggaaa cheggaaa merged commit d282636 into cheggaaa:master Aug 6, 2020
@cheggaaa
Copy link
Owner

cheggaaa commented Aug 6, 2020

It's awesome!

@fhs
Copy link
Contributor Author

fhs commented Aug 6, 2020

@cheggaaa Can we also tag v1.0.29? go-ipfs is still using v1.

@fhs fhs deleted the plan9 branch August 6, 2020 14:44
@cheggaaa
Copy link
Owner

cheggaaa commented Aug 6, 2020

@fhs done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants