Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid ssl alert bad certificate error from ssl clients #348

Closed
wants to merge 1 commit into from

Conversation

nizamial09
Copy link

@nizamial09 nizamial09 commented Dec 8, 2020

This commit is to avoid the alert bad certificate error that keeps happening when some requests.

Signed-off-by: Nizamudeen A [email protected]

What kind of change does this PR introduce?

  • 🐞 bug fix
  • 🐣 feature
  • 📋 docs update
  • 📋 tests/coverage improvement
  • 📋 refactoring
  • 💥 other

📋 What is the related issue number (starting with #)

#347

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

📋 Other information:

📋 Checklist:

  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

This change is Reviewable

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a test and it shouldn't generate linter offenses.

@nizamial09 nizamial09 force-pushed the alert-bad-certificate branch from 1bd9ef5 to a31cfea Compare December 8, 2020 14:34
@webknjaz webknjaz added the reproducer: missing This PR or issue lacks code, which reproduce the problem described or clearly understandable STR label Dec 8, 2020
This commit is to avoid the alert bad certificate error that keeps happening when some requests.

Signed-off-by: Nizamudeen A <[email protected]>
@webknjaz
Copy link
Member

webknjaz commented Dec 8, 2020

@nizamial09 the commit is not linked to your GitHub account. You need to either add the committer email to GitHub or fix your local Git setup.

Also, fill out the PR template. It doesn't have any explanation currently.

@nizamial09 nizamial09 force-pushed the alert-bad-certificate branch from a31cfea to eec6cc0 Compare December 8, 2020 14:42
@nizamial09
Copy link
Author

@nizamial09 the commit is not linked to your GitHub account. You need to either add the committer email to GitHub or fix your local Git setup.

Also, fill out the PR template. It doesn't have any explanation currently.

Okay. I'll take care of that and will update it.

nizamial09 added a commit to rhcs-dashboard/ceph that referenced this pull request Dec 8, 2020
@webknjaz
Copy link
Member

webknjaz commented Dec 8, 2020

I'll mark it as a draft until ready

@webknjaz webknjaz marked this pull request as draft December 8, 2020 20:28
nizamial09 added a commit to rhcs-dashboard/ceph that referenced this pull request Dec 9, 2020
…iders error

upstream tracked in cherrypy/cheroot#348
Fixes: https://tracker.ceph.com/issues/48490
Signed-off-by: Nizamudeen A <[email protected]>
(cherry picked from commit 4cbe89f)
nizamial09 added a commit to rhcs-dashboard/ceph that referenced this pull request Dec 9, 2020
…iders error

upstream tracked in cherrypy/cheroot#348
Fixes: https://tracker.ceph.com/issues/48490
Signed-off-by: Nizamudeen A <[email protected]>
(cherry picked from commit 4cbe89f)
jmolmo pushed a commit to jmolmo/ceph that referenced this pull request Dec 14, 2020
@nizamial09
Copy link
Author

I couldn't reproduce this.

@nizamial09 nizamial09 closed this Jan 19, 2021
vshankar pushed a commit to ceph/ceph-ci that referenced this pull request Jun 7, 2021
…iders error

upstream tracked in cherrypy/cheroot#348

Resolves: rhbz#1904340

Signed-off-by: Nizamudeen A <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reproducer: missing This PR or issue lacks code, which reproduce the problem described or clearly understandable STR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants