Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust traceback-matching patterns in tests for Python 3.11 #1965

Closed
wants to merge 1 commit into from

Conversation

hroncok
Copy link

@hroncok hroncok commented Jun 16, 2022

What kind of change does this PR introduce?

  • bug fix
  • feature
  • docs update
  • tests/coverage improvement
  • refactoring
  • other

What is the related issue number (starting with #)

Fedora downstream report: https://bugzilla.redhat.com/show_bug.cgi?id=2081670

What is the current behavior? (You can also link to an open issue here)

Test failures.

    ERROR: Error page does not contain '\n    raise ValueError()\nValueError' in traceback

What is the new behavior (if this is a feature change)?

Tests passing.

Other information:

Checklist:

  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

@hroncok
Copy link
Author

hroncok commented Jun 16, 2022

I've opened this here because I needed it in Fedora, but I am currently herding dozens of similar issues as the Fedora's Python 3.11 mass rebuild is in progress. I won't be able to dedicate my time to fixing any style issues, changelog fragments, or similar things. Sorry about that. Feel free to adjust this in any way you see fit or even close it if it's not up to the project's standards.

@hroncok
Copy link
Author

hroncok commented Jul 15, 2022

This needs adjustments for 3.11.0b4.

@hroncok hroncok marked this pull request as draft July 15, 2022 14:17
@hroncok
Copy link
Author

hroncok commented Jul 15, 2022

See python/cpython#93883 and python/cpython#93994

The required changes basically mean this can be dropped entirely.

@hroncok hroncok closed this Jul 15, 2022
@hroncok hroncok deleted the py3.11 branch July 15, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant