Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tagged version for ilammy/msvc-dev-cmd #163

Closed
wants to merge 1 commit into from

Conversation

Chocobo1
Copy link
Member

So it won't get outdated when there is a new minor release.

So it won't get outdated when there is a new minor release.
@Chocobo1 Chocobo1 changed the title ci: Use tagged version for ilammy/msvc-dev-cmd Use tagged version for ilammy/msvc-dev-cmd May 30, 2024
@kanru
Copy link
Member

kanru commented May 30, 2024

Can pinned version update be automated? I think it's good pin the action version.

https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions

@Chocobo1
Copy link
Member Author

Can pinned version update be automated?

It seems yes and we already have dependabot enabled.
In addition, it seems dependabot is able to bump the trailing comment if it is related to the version:
Example: nodejs/node#51334
Source code: dependabot/dependabot-core#5951

I'll close this PR and submit another one to add the version in comment.

@Chocobo1 Chocobo1 closed this May 31, 2024
@Chocobo1 Chocobo1 deleted the ci branch May 31, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants