intx: Add as_bytes() helper for casting intx to bytes #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
==========================================
- Coverage 70.42% 66.98% -3.44%
==========================================
Files 8 8
Lines 1349 1360 +11
Branches 157 158 +1
==========================================
- Hits 950 911 -39
- Misses 351 401 +50
Partials 48 48 |
axic
reviewed
Aug 15, 2019
| const auto b = as_bytes(x); | ||
| EXPECT_EQ(b[0], 5); | ||
| EXPECT_EQ(b[1], 0xa); |
There was a problem hiding this comment.
This codifies it as little endian. Should this be implemented for both be/le ?
There was a problem hiding this comment.
I have to add big endian support in general. But not a priority in the moment. I only have time to add features needed in other EVM projects.
There was a problem hiding this comment.
Well EVM is big endian, isn't it?
There was a problem hiding this comment.
Correct, but this API is needed for intx::be API and in one place in evmone. It exposes internal representation as bytes.
There was a problem hiding this comment.
So perhaps can you move as_bytes into intx::be ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.