Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fixes documentation for examples #93

Merged
merged 1 commit into from
Sep 29, 2022
Merged

chore: Fixes documentation for examples #93

merged 1 commit into from
Sep 29, 2022

Conversation

aquaflamingo
Copy link
Contributor

Provide a general summary of your changes

Description

Update README for the example to use the proper enum value (not capitalized)

Motivation and Context

Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here.

How Has This Been Tested?

Please describe in detail how you tested your changes.

Types of changes

  • Bug fix 🐛 (non-breaking change which fixes an issue)
  • New feature ✨ (non-breaking change which adds functionality)
  • Breaking change 💥 (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project 🍻.
  • My change requires a change to the documentation 💡 and I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document 👥.
  • I have added tests to cover my changes 🎉.
  • All new and existing tests passed ✅.

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #93 (c69f5b8) into main (d2906ef) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files         153      153           
  Lines        4266     4266           
=======================================
  Hits         4051     4051           
  Misses        215      215           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chicio chicio merged commit d558797 into chicio:main Sep 29, 2022
@chicio
Copy link
Owner

chicio commented Sep 29, 2022

Thanks @aquaflamingo for the PR. 🙇

@chicio
Copy link
Owner

chicio commented Oct 2, 2022

Going to release today. I will add you to the contributors. Thanks again for the support 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants