Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add padding in groups to be able to see the last item #58

Merged

Conversation

igas
Copy link
Contributor

@igas igas commented Aug 26, 2023

Description

When many groups exist, last group is hidden past the screen.

Fixes #57 (partially)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TEST_LONG_LIST_OF_GROUPS=1 yarn test

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@chiefpansancolt chiefpansancolt self-requested a review November 21, 2023 22:17
@chiefpansancolt chiefpansancolt changed the base branch from main to preview November 21, 2023 22:18
@chiefpansancolt chiefpansancolt self-assigned this Nov 21, 2023
@chiefpansancolt chiefpansancolt added the bug Something isn't working label Nov 22, 2023
@chiefpansancolt chiefpansancolt added this to the Version 2.2.0 milestone Nov 22, 2023
Copy link
Owner

@chiefpansancolt chiefpansancolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chiefpansancolt chiefpansancolt merged commit fc14cdf into chiefpansancolt:preview Nov 22, 2023
@igas igas deleted the add-last-group-padding branch December 4, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

[Bug]: Left hand sidebar cut off and unscrollable
2 participants