Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some updates #20

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Some updates #20

wants to merge 5 commits into from

Conversation

akstrfn
Copy link
Contributor

@akstrfn akstrfn commented Jul 23, 2019

  • Restored previous functionality of the counts that was removed when overleaf was added.
  • Added dependency on currfile package to remove requirement to name the file trb_template.
  • Word count file is removed when counting is done.
  • Add line numbers to equation environment.
  • Restore space around equations

@chiehrosswang
Copy link
Owner

@akstrfn thanks for submitting the PR. However, I couldn't get your branch working properly in Overleaf. Have you test it in Overleaf? I want to make sure any updates we make can work properly in both local and server-based environments.

@akstrfn
Copy link
Contributor Author

akstrfn commented Jul 23, 2019 via email

@chiehrosswang
Copy link
Owner

I think the error occurs in the \quickwordcount function. It took me a while to get my current master to work both in Overleaf.com and TexStudio on my PC.

I know Overleaf uses latexkmrc, I am using it in the current master.

@chiehrosswang
Copy link
Owner

For word count, I integrated the method suggested by Sharelatex/Overleaf staff here.

@akstrfn
Copy link
Contributor Author

akstrfn commented Jul 23, 2019

I've seen that solution but it is a very poor one because it forces everyone into having the same filename just for the sake of Overleaf. It was better if just for overleap the file was named output.tex which should work if I understand the explanation well. If currfile package works in Overleaf I'm not certain what could be the problem.

I think the package should be kept as general as possible and not tuned for Overleaf. The answer you had in your first question is the one that takes care of more corner cases and is much more general, the only problem is the jobname being a compiler switch (which probably most people don't touch). I did a quick search into obtaining a filename and it seemed like its not so easy so maybe some workaround with latexmkrc could do the trick.

@akstrfn
Copy link
Contributor Author

akstrfn commented Jul 23, 2019

Another issue could be removal of the file with rm which should just error but not mess up the compilation but I'm not sure. Can you test this?

@chiehrosswang
Copy link
Owner

I will take a look and test it probably next week - sorry, this week is a bit crazy...

@akstrfn
Copy link
Contributor Author

akstrfn commented Jul 25, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants