Overload bids2table
signature for specific return types
#39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of typehinting
BIDSTable | None
for the return type ofbids2table
, this PR updates the typehinting to dynamically beBIDSTable
forbids2table(return_table=True)
(or unspecified, which withreturn_table=True
by default) orNone
forbids2table(return_table=False)
.screen-capture.webm
The functionality is the same between just a4bcf5e or both commits here. The difference is the first commit does the overload in the main file
bids2table/bids2table/_b2t.py
Lines 16 to 56 in a4bcf5e
No hard feelings if you don't want this specific typehinting.