Regenerate value-keys (upper-case id) #185
Conversation
| @@ -3,7 +3,7 @@ | |||
| "name": "1dCorrelate", | |||
| "author": "AFNI Developers", | |||
| "description": "1dCorrelate calculates the correlation coefficients between columns of input 1D files along with confidence intervals via a bootstrap procedure.", | |||
| "command-line": "1dCorrelate [METHOD] [BOOTSTRAP_REPLICATES] [CONFIDENCE_INTERVAL] [BLOCK_RESAMPLING] [INPUT_FILES]", | |||
| "command-line": "1dCorrelate [KTAUB] [NBOOT] [ALPHA] [BLK] [INPUT_FILES]", | |||
There was a problem hiding this comment.
Method here has been replaced by the last correlation option, disabling all the other flags.
| @@ -5,15 +5,15 @@ | |||
| "descriptor-url": "https://github.com/afni/afni/blob/master/src/1dMarry.c", | |||
| "description": "Joins together 2 (or more) ragged-right .1D files, for use with 3dDeconvolve -stim_times_AM2, or breaks up 1 married file into 2 (or more) single-valued files.", | |||
| "url": "https://afni.nimh.nih.gov/", | |||
| "command-line": "1dMarry [SEPARATORS] [DIVORCE_FLAG] [FILE1] [FILE2]", | |||
| "command-line": "1dMarry [SEP] [DIVORCE] [FILES] [FILE2]", | |||
There was a problem hiding this comment.
I think we can remove [FILE2] here
| @@ -20,7 +20,7 @@ | |||
| }, | |||
| { | |||
| "description": "Output prefix. See also -save.", | |||
| "value-key": "[PREFIX]", | |||
| "value-key": "[OUTPUT_PREFIX]", | |||
There was a problem hiding this comment.
All the values here and below are missing in the command-line.
| @@ -50,7 +50,7 @@ | |||
| { | |||
| "command-line-flag": "-max_iter", | |||
| "description": "Maximum number of iterations for convergence (Default=10000). Values can range from 1 to any positive integer less than 10000.", | |||
| "value-key": "[MAX_ITER]", | |||
| "value-key": "[MAX_ITERATIONS]", | |||
There was a problem hiding this comment.
Here and below not in command line
| @@ -18,7 +18,7 @@ | |||
| { | |||
| "command-line-flag": "-inc", | |||
| "description": "Sort into increasing order [default]", | |||
| "value-key": "[ORDER_OPTION]", | |||
| "value-key": "[INC_ORDER]", | |||
| @@ -29,7 +29,7 @@ | |||
| { | |||
| "command-line-flag": "-bin", | |||
| "description": "Write data in binary format", | |||
| "value-key": "[BINARY_FLAG]", | |||
| "value-key": "[BINARY]", | |||
There was a problem hiding this comment.
Both here and below aren't in command-line
| @@ -3,7 +3,7 @@ | |||
| "name": "3dAFNItoANALYZE", | |||
| "author": "AFNI Developers", | |||
| "description": "Writes AFNI dataset to ANALYZE 7.5 format .hdr/.img file pairs.", | |||
| "command-line": "3dAFNItoANALYZE [4D_FLAG] [ORIENT_FLAG] [OUTPUT_NAME] [DSET]", | |||
| "command-line": "3dAFNItoANALYZE [4D_OPTION] [ORIENT_OPTION] [OUTPUT_NAME] [AFNI_DATASET]", | |||
There was a problem hiding this comment.
AFNI_DATASET missing in inputs
| @@ -20,7 +20,7 @@ | |||
| { | |||
| "command-line-flag": "-data", | |||
| "description": "Also put the data into the output (will be huge).", | |||
| "value-key": "[DATA_FLAG]", | |||
| "value-key": "[DATA]", | |||
There was a problem hiding this comment.
Here and below missing in command-line
| @@ -283,7 +283,7 @@ | |||
| }, | |||
| { | |||
| "description": "Specify the output file for the interaction contrast results between A and B (case-sensitive).", | |||
| "value-key": "[OUTFILE_ABCONTR_CASE]", | |||
| "value-key": "[OUTFILE_ABCONTR]", | |||
There was a problem hiding this comment.
All OUTFILE_* keys aren't included in command-line
| @@ -3,7 +3,7 @@ | |||
| "name": "3dAmpToRSFC", | |||
| "author": "AFNI Developers", | |||
| "description": "Convert spectral amplitudes into standard RSFC parameters.", | |||
| "command-line": "3dAmpToRSFC { [INPUT_AMPS] | [INPUT_POWS] } [PREFIX] [FBOT] [FTOP] { [MASK] } { -nifti }", | |||
| "command-line": "3dAmpToRSFC { [IN_AMP] | [IN_POW] } [PREFIX] [BAND] { [MASK] } { -nifti }", | |||
There was a problem hiding this comment.
What is happening here with the curly braces (is this how the command calls it?)
There was a problem hiding this comment.
LGTM - I didn't go through all of them in detail given the new test to be run (shown offline). Nothing changed in terms of command-line flags.
One noted issue when I first started doing the review in more depth was that anything that contained OPTION had mismatched command-line and input arguments. This can be fixed in a later PR, but just wanted to note it.
No description provided.