Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes #189

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Various fixes #189

merged 3 commits into from
Dec 2, 2024

Conversation

nx10
Copy link
Contributor

@nx10 nx10 commented Nov 28, 2024

No description provided.

@nx10 nx10 marked this pull request as ready for review December 1, 2024 17:41
@nx10 nx10 requested a review from kaitj December 1, 2024 17:41
kaitj
kaitj approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@kaitj kaitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just the one question about the file where [OPTIONS] had a matching input previously.

descriptors/freesurfer/mri_topologycorrection.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one might need a second look - this is the first command I've seen where [OPTIONS] had a matching input.

@nx10 nx10 merged commit 577b9f4 into main Dec 2, 2024
@nx10 nx10 deleted the various-fixes branch December 17, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaitj kaitj kaitj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nx10 @kaitj