Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(holography) : add quality_flag = 4 for CHIME noise source off #23

Merged
merged 7 commits into from
Feb 15, 2022

Conversation

ashill
Copy link
Contributor

@ashill ashill commented Feb 14, 2022

(most commonly because 26 m in non-CHIME observing state)

Combined with a companion change to alpenhorn_holography, allow setting quality_flag = 4 for holography observations when the CHIME noise source is off, most commonly these days because non-CHIME observations are occurring using a non-CHIME noise source.

(most commonly because 26 m in non-CHIME observing state)
@ashill ashill marked this pull request as draft February 14, 2022 23:11
Copy link
Contributor

@tristpinsm tristpinsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a small change I think would be necessary

@ashill ashill marked this pull request as ready for review February 15, 2022 05:03
@ashill ashill requested a review from tristpinsm February 15, 2022 05:08
@ashill
Copy link
Contributor Author

ashill commented Feb 15, 2022

Looks good! Just a small change I think would be necessary

Fixed now.

@ashill ashill merged commit b02709e into master Feb 15, 2022
@ashill ashill deleted the 26m_qualityflags branch February 15, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants