fix(requirements): Bump peewee requirement to 3.14.1 or newer #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layout is affected by coleifer/peewee#2304
jrs65
approved these changes
Jun 15, 2022
|
Nice detective work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a
layout.Componentinstance to look up alayout.Connexionwe appear to have been affected by coleifer/peewee#2304 which was fixed in Peewee 3.14.1.This was most noticeable when using
from_pair(comp1, comp2).This bug is also the reason we had to make this fix: https://github.com/chime-experiment/ch_util_private/pull/34 (which didn't make any sense to me at the time)
Peewee-2 was not affected by this bug, which is why this code worked when we originally created the layout API.