Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add end times to static masking #56

Merged
merged 3 commits into from
Apr 20, 2023
Merged

Add end times to static masking #56

merged 3 commits into from
Apr 20, 2023

Conversation

ljgray
Copy link
Contributor

@ljgray ljgray commented Apr 19, 2023

Add specification of end times for static rfi masking so we can unmask a band if the rfi source shuts off.

I haven't actually updated the list of bad frequencies with known end times yet.

@ljgray ljgray marked this pull request as ready for review April 19, 2023 23:49
@ljgray ljgray requested review from hgan0 and jrs65 April 20, 2023 19:18
hgan0
hgan0 previously approved these changes Apr 20, 2023
Copy link
Contributor

@hgan0 hgan0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the end time to the mask. It looks good to me.
I think the list of bad frequencies may be added later.

@jrs65
Copy link
Contributor

jrs65 commented Apr 20, 2023

Sweet, I was just thinking of doing this.

You might as well add the end times for those bands in there while you're on. Let me just go and dig into those spectrum plots to figure them out and I'll post them here.

@jrs65
Copy link
Contributor

jrs65 commented Apr 20, 2023

End dates:

  • TV channel 27 (548–554 MHz): 2022-08-24
  • TV channel 32 (578–584 MHz): 2022-08-25

They're both definitely gone by midnight UTC on those dates,

- 548 - 554 MHz ending CSD 3212 inclusive
- 578 - 584 ending CSD 2313 inclusive
@ljgray
Copy link
Contributor Author

ljgray commented Apr 20, 2023

@jrs65 I've added those bands, which end on CSD 3212 and 3213 (inclusive) respectively (i.e. the first good day for the bands are 3213 and 3214). Can you confirm that that's correct, or would CSD 3212 and 3213 be the first days without the bands?

This allows the array arguments in `frequency_mask` to be broadcast
against each other to produce the output.
@ljgray ljgray merged commit f4a2ec4 into master Apr 20, 2023
@ljgray ljgray deleted the ljg/static-mask-time branch April 20, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants