feat(ephemeris): Import functions moved to caput #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikvl
previously approved these changes
Jul 16, 2024
ljgray
previously approved these changes
Jul 16, 2024
In radiocosmology/caput#269: * `ch_util.ephemeris.sphdist` has been moved to `caput.interferometry.sphdist` * `drift.telescope.cylbeam.rotate_ypr` has been moved to `caput.interferometry.rotate_ypr` Updated `ch_util/holography.py` to use the caput version of `sphdist` directly. This removes the `driftscan` dependency.
ketiltrout
force-pushed
the
rotate_ypr-and-sphdist-from-caput
branch
from
3bdbb24 to
906c904
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In radiocosmology/caput#269:
ch_util.ephemeris.sphdisthas been moved tocaput.interferometry.sphdistdrift.telescope.cylbeam.rotate_yprhas been moved tocaput.interferometry.rotate_yprUpdated
ch_util/holography.pyto use the caput version ofsphdistdirectly.This removes the
driftscandependency.(I don't know if anything else besides the holography module uses
sphdist, but I see no harm in re-importing it toephemeris.)