allowReflectiveAutoCloneType must work outside of Builder context #1811
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some 2.11 tests caught this issue in #1810 since they don't run with the plugin.
Because this is already fixed there, this PR doesn't need backporting.
Basically, the problem is that the check I added in #1804 for disabling reflective autoclonetype triggers if reflective autoclonetype happens outside of a Builder context. This changes makes
Builder.allowReflectiveAutoCloneType
succeed if there is noDynamicContext
. BecauseallowReflectiveAutoCloneType
is only used in testing, this is the correct thing to do.Contributor Checklist
docs/src
?As a bug fix to a not-yet-released feature, no release notes for this particular PR
Type of Improvement
API Impact
No impact
Backend Code Generation Impact
No impact
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
Please Merge
?