Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowReflectiveAutoCloneType must work outside of Builder context #1811

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

jackkoenig
Copy link
Contributor

Some 2.11 tests caught this issue in #1810 since they don't run with the plugin.
Because this is already fixed there, this PR doesn't need backporting.

Basically, the problem is that the check I added in #1804 for disabling reflective autoclonetype triggers if reflective autoclonetype happens outside of a Builder context. This changes makes Builder.allowReflectiveAutoCloneType succeed if there is no DynamicContext. Because allowReflectiveAutoCloneType is only used in testing, this is the correct thing to do.

Contributor Checklist

  • [NA] Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • [NA] Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • [NA] Did you add text to be included in the Release Notes for this change?

As a bug fix to a not-yet-released feature, no release notes for this particular PR

Type of Improvement

  • bug fix

API Impact

No impact

Backend Code Generation Impact

No impact

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (3.2.x, 3.3.x, 3.4.0, 3.5.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label Mar 14, 2021
@jackkoenig jackkoenig added this to the 3.5.0 milestone Mar 14, 2021
@jackkoenig jackkoenig requested a review from ducky64 March 15, 2021 20:47
Copy link
Contributor

@ducky64 ducky64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackkoenig jackkoenig merged commit 96436ae into master Mar 15, 2021
@jackkoenig jackkoenig deleted the support-reflective-clonetype-outside-of-builder branch March 15, 2021 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants