Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide useful message on Vec.apply require #1838

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Provide useful message on Vec.apply require #1838

merged 1 commit into from
Mar 29, 2021

Conversation

jackkoenig
Copy link
Contributor

Contributor Checklist

  • [NA] Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • bug fix

API Impact

No impact

Backend Code Generation Impact

No impact

Desired Merge Strategy

  • Squash

Release Notes

Provide explanation on requirement that Vec values be non-empty

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (3.2.x, 3.3.x, 3.4.0, 3.5.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@jackkoenig jackkoenig added this to the 3.2.x milestone Mar 29, 2021
@jackkoenig jackkoenig added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Mar 29, 2021
@mergify mergify bot merged commit 9c9bc13 into master Mar 29, 2021
mergify bot pushed a commit that referenced this pull request Mar 29, 2021
@jackkoenig
Provide useful message on Vec.apply require (#1838)
db13035 
(cherry picked from commit 9c9bc13)
@mergify mergify bot mentioned this pull request Mar 29, 2021
Merged
mergify bot pushed a commit that referenced this pull request Mar 29, 2021
@jackkoenig
Provide useful message on Vec.apply require (#1838)
cafd753 
(cherry picked from commit 9c9bc13)
@mergify mergify bot mentioned this pull request Mar 29, 2021
Merged
mergify bot pushed a commit that referenced this pull request Mar 29, 2021
@jackkoenig
Provide useful message on Vec.apply require (#1838)
826ee3f 
(cherry picked from commit 9c9bc13)
@mergify mergify bot added the Backported This PR has been backported label Mar 29, 2021
@mergify mergify bot mentioned this pull request Mar 29, 2021
Merged
mergify bot added a commit that referenced this pull request Mar 29, 2021
@mergify @jackkoenig
Provide useful message on Vec.apply require (#1838) (#1839)
3889c86 
(cherry picked from commit 9c9bc13)

Co-authored-by: Jack Koenig <[email protected]>
mergify bot added a commit that referenced this pull request Mar 29, 2021
@mergify @jackkoenig
Provide useful message on Vec.apply require (#1838) (#1840)
e0921f2 
(cherry picked from commit 9c9bc13)

Co-authored-by: Jack Koenig <[email protected]>
mergify bot added a commit that referenced this pull request Mar 29, 2021
@mergify @jackkoenig
Provide useful message on Vec.apply require (#1838) (#1841)
1102c02 
(cherry picked from commit 9c9bc13)

Co-authored-by: Jack Koenig <[email protected]>
@jackkoenig jackkoenig deleted the vec-apply-require-msg branch April 6, 2021 18:33
@MAFOR-TECH MAFOR-TECH mentioned this pull request Oct 24, 2021
Closed
@sequencer sequencer mentioned this pull request Nov 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge seldridge approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
3.2.x
Development

Successfully merging this pull request may close these issues.
2 participants
@jackkoenig @seldridge