Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Instance.suggestName #2886

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Add Instance.suggestName #2886

merged 4 commits into from
Jan 10, 2024

Conversation

tymcauley
Copy link
Contributor

@tymcauley tymcauley commented Dec 13, 2022 •
edited
Loading

This supersedes #2414, which I think is abandoned. Resolves #2366.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • new feature/API

API Impact

Adds suggestName API for hierarchy instances.

Backend Code Generation Impact

Allows users to control Verilog module instance names.

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference.

Release Notes

Adds suggestName API for hierarchy instances.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@tymcauley tymcauley marked this pull request as draft December 13, 2022 00:13
@tymcauley tymcauley changed the title Di suggestName redux Draft: DI suggestName redux Dec 13, 2022
@tymcauley tymcauley changed the title Draft: DI suggestName redux Draft: D/I suggestName redux Dec 13, 2022
@jackkoenig jackkoenig force-pushed the di-suggestname-redux branch from c8069c8 to f834fca Compare January 9, 2024 02:26
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 9, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@jackkoenig jackkoenig added the Feature New feature, will be included in release notes label Jan 9, 2024
@jackkoenig jackkoenig marked this pull request as ready for review January 9, 2024 02:26
@jackkoenig jackkoenig changed the title Draft: D/I suggestName redux Add Instance.suggestName Jan 10, 2024
@jackkoenig jackkoenig added this to the 3.6.x milestone Jan 10, 2024
@jackkoenig jackkoenig enabled auto-merge (squash) January 10, 2024 00:34
@jackkoenig
Copy link
Contributor

We really should clean up ModuleClone, but this focused tweak is useful and can be backported.

@jackkoenig jackkoenig merged commit 24de2f2 into chipsalliance:main Jan 10, 2024
14 checks passed
@mergify mergify bot added the Backported This PR has been backported label Jan 10, 2024
mergify bot pushed a commit that referenced this pull request Jan 10, 2024
@tymcauley @mergify
Add Instance.suggestName (#2886)
3a8298c 
Co-authored-by: Aditya Naik <[email protected]>
Co-authored-by: Jack Koenig <[email protected]>
(cherry picked from commit 24de2f2)
@mergify mergify bot mentioned this pull request Jan 10, 2024
Merged
16 tasks
mergify bot pushed a commit that referenced this pull request Jan 10, 2024
@tymcauley @mergify
Add Instance.suggestName (#2886)
ffd9f74 
Co-authored-by: Aditya Naik <[email protected]>
Co-authored-by: Jack Koenig <[email protected]>
(cherry picked from commit 24de2f2)
@mergify mergify bot mentioned this pull request Jan 10, 2024
Merged
16 tasks
@tymcauley tymcauley deleted the di-suggestname-redux branch January 10, 2024 21:26
jackkoenig added a commit that referenced this pull request Jan 12, 2024
@jackkoenig
Add Instance.suggestName (#2886)
c9b1bae 
Co-authored-by: Aditya Naik <[email protected]>
Co-authored-by: Tynan McAuley <[email protected]>
(cherry picked from commit 24de2f2)
mergify bot added a commit that referenced this pull request Jan 12, 2024
@mergify @jackkoenig
Add Instance.suggestName (#2886) (#3724)
213f89f 
Co-authored-by: Aditya Naik <[email protected]>
Co-authored-by: Tynan McAuley <[email protected]>
(cherry picked from commit 24de2f2)

Co-authored-by: Jack Koenig <[email protected]>
jackkoenig pushed a commit that referenced this pull request Jan 27, 2024
@adkian-sifive @jackkoenig
Add Instance.suggestName (#2886)
dbb2365 
Co-authored-by: Jack Koenig <[email protected]>
(cherry picked from commit 24de2f2)
jackkoenig pushed a commit that referenced this pull request Jan 27, 2024
@adkian-sifive @jackkoenig
Add Instance.suggestName (#2886)
3e08a79 
Co-authored-by: Jack Koenig <[email protected]>
(cherry picked from commit 24de2f2)
jackkoenig pushed a commit that referenced this pull request Jan 27, 2024
@mergify
Add Instance.suggestName (#2886) (#3723)
7690cd6 
Co-authored-by: Aditya Naik <[email protected]>
Co-authored-by: Jack Koenig <[email protected]>
(cherry picked from commit 24de2f2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Feature New feature, will be included in release notes
Projects
None yet
Milestone
3.6.x
Development

Successfully merging this pull request may close these issues.

Hierarchy API doesn't allow custom instance names
3 participants
@tymcauley @jackkoenig @adkian-sifive