Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where Flipped did not properly flip #2919

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Conversation

jackkoenig
Copy link
Contributor

In cases when Flipped needs to clone, it was using the specified direction of the clone. Since cloneType does not propagate specifiedDirection, it was essentially always flipping an unspecified direction even if the direction had been specified.

This bug was introduced by the optimizations in #2611 so it only applies to 3.6.

Contributor Checklist

  • [NA] Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • bug fix

API Impact

No impact

Backend Code Generation Impact

No impact

Desired Merge Strategy

  • Squash

Release Notes

Fix bug where Flipped would not actually flip when the argument is assigned to a val before being passed to Flipped.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

In cases when Flipped needs to clone, it was using the specified
direction of the clone. Since cloneType does not propagate
specifiedDirection, it was essentially always flipping an unspecified
direction even if the direction had been specified.
@jackkoenig jackkoenig added this to the 3.6.0 milestone Jan 5, 2023
@jackkoenig jackkoenig requested review from azidar and mwachs5 January 5, 2023 01:19
@jackkoenig jackkoenig merged commit 643ee29 into master Jan 5, 2023
@jackkoenig jackkoenig deleted the fix-flipped branch January 5, 2023 01:23
Copy link
Contributor

@mwachs5 mwachs5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants