-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize BitPat equals, overlap, and cover #3285
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chick
approved these changes
May 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mergify bot
pushed a commit
that referenced
this pull request
May 17, 2023
(cherry picked from commit f590ac9)
mergify bot
pushed a commit
that referenced
this pull request
May 17, 2023
(cherry picked from commit f590ac9)
mergify bot
pushed a commit
that referenced
this pull request
May 17, 2023
(cherry picked from commit f590ac9)
This was referenced May 17, 2023
mergify bot
added a commit
that referenced
this pull request
May 18, 2023
* Optimize BitPat equals, overlap, and cover (#3285) (cherry picked from commit f590ac9) * Fix binary compatibility issue --------- Co-authored-by: Jack Koenig <[email protected]>
mergify bot
added a commit
that referenced
this pull request
May 18, 2023
* Optimize BitPat equals, overlap, and cover (#3285) (cherry picked from commit f590ac9) * Fix binary compatibility issue --------- Co-authored-by: Jack Koenig <[email protected]>
mergify bot
added a commit
that referenced
this pull request
May 18, 2023
* Optimize BitPat equals, overlap, and cover (#3285) (cherry picked from commit f590ac9) * Fix binary compatibility issue --------- Co-authored-by: Jack Koenig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backported
This PR has been backported
Performance
Improves performance, will be included in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added some focused tests.
I am making this change because I noticed slow performance for a
TruthTable
that has 65k entries. The performance of just==
on thatTruthTable
was pretty bad. Note that==
forBitSet
usescover
, so I first optimized that, then went ahead and also optimizedequals
, and thenoverlap
was free so did that too. See benchmark for equality of two copies of aTruthTable
with 65k entries:There are other improvements to be made, but this is pretty good and constrained.
Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.5.x
or3.6.x
depending on impact, API modification or big change:5.0.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.