Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize BitPat equals, overlap, and cover #3285

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

jackkoenig
Copy link
Contributor

@jackkoenig jackkoenig commented May 17, 2023

I also added some focused tests.

I am making this change because I noticed slow performance for a TruthTable that has 65k entries. The performance of just == on that TruthTable was pretty bad. Note that == for BitSet uses cover, so I first optimized that, then went ahead and also optimized equals, and then overlap was free so did that too. See benchmark for equality of two copies of a TruthTable with 65k entries:

Change Runtime Speedup over Baseline
Baseline 68 ms -
Optimize cover 3.9 ms 17x
Optimize equals 1.3 ms 52x

There are other improvements to be made, but this is pretty good and constrained.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Performance improvement

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x or 3.6.x depending on impact, API modification or big change: 5.0.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Performance Improves performance, will be included in release notes label May 17, 2023
@jackkoenig jackkoenig added this to the 3.5.x milestone May 17, 2023
Copy link
Contributor

@chick chick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackkoenig jackkoenig merged commit f590ac9 into main May 17, 2023
@jackkoenig jackkoenig deleted the optimize-bitpat branch May 17, 2023 20:03
@mergify mergify bot added the Backported This PR has been backported label May 17, 2023
mergify bot pushed a commit that referenced this pull request May 17, 2023
mergify bot pushed a commit that referenced this pull request May 17, 2023
mergify bot pushed a commit that referenced this pull request May 17, 2023
mergify bot added a commit that referenced this pull request May 18, 2023
* Optimize BitPat equals, overlap, and cover (#3285)

(cherry picked from commit f590ac9)

* Fix binary compatibility issue

---------

Co-authored-by: Jack Koenig <[email protected]>
mergify bot added a commit that referenced this pull request May 18, 2023
* Optimize BitPat equals, overlap, and cover (#3285)

(cherry picked from commit f590ac9)

* Fix binary compatibility issue

---------

Co-authored-by: Jack Koenig <[email protected]>
mergify bot added a commit that referenced this pull request May 18, 2023
* Optimize BitPat equals, overlap, and cover (#3285)

(cherry picked from commit f590ac9)

* Fix binary compatibility issue

---------

Co-authored-by: Jack Koenig <[email protected]>
@sequencer sequencer mentioned this pull request Jun 20, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Performance Improves performance, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants