Sanitize Record._elements #3419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves name sanitation a little earlier and ensures that the sanitized names are use more consistently throughout Chisel internals. This fixes a bug in D/I where unsanitary names would lead to a crash.
jackkoenig
force-pushed
the
sanitize-record-elements-earlier
branch
from
40e1b78 to
c77bc70
Compare
azidar
approved these changes
Jul 14, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jul 14, 2023
This moves name sanitation a little earlier and ensures that the sanitized names are use more consistently throughout Chisel internals. This fixes a bug in D/I where unsanitary names would lead to a crash. (cherry picked from commit 5c282db)
mergify bot
pushed a commit
that referenced
this pull request
Jul 14, 2023
This moves name sanitation a little earlier and ensures that the sanitized names are use more consistently throughout Chisel internals. This fixes a bug in D/I where unsanitary names would lead to a crash. (cherry picked from commit 5c282db)
This was referenced Jul 14, 2023
mergify bot
added a commit
that referenced
this pull request
Jul 17, 2023
* Sanitize Record._elements (#3419) This moves name sanitation a little earlier and ensures that the sanitized names are use more consistently throughout Chisel internals. This fixes a bug in D/I where unsanitary names would lead to a crash. (cherry picked from commit 5c282db) * Keep Scala 2.12 support by not using VectorMap * Fix firrtl in tests for older firrtl spec version --------- Co-authored-by: Jack Koenig <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Jul 17, 2023
* Sanitize Record._elements (#3419) This moves name sanitation a little earlier and ensures that the sanitized names are use more consistently throughout Chisel internals. This fixes a bug in D/I where unsanitary names would lead to a crash. (cherry picked from commit 5c282db) * Keep Scala 2.12 support by not using VectorMap * Fix firrtl in tests for older firrtl spec version --------- Co-authored-by: Jack Koenig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves name sanitation a little earlier and ensures that the sanitized names are use more consistently throughout Chisel internals.
This fixes a bug in D/I where unsanitary names would lead to a crash.
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Fixes a bug in D/I where unsanitary names would lead to a crash. It also makes the Printable output for Bundles and Records use the sanitary names which makes them better match the FIRRTL.
Reviewer Checklist (only modified by reviewer)
3.5.x,3.6.x, or5.xdepending on impact, API modification or big change:6.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.