Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static shift right width change part 2 #3841

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

jackkoenig
Copy link
Contributor

  • Apply some suggestions from post-merge code review
  • Add "use" to CLI option: --use-legacy-shift-right-width
  • Improve stability of emitted FIRRTL and Verilog when using legacy option
  • DRY out the tests

Follow on to #3824

Note I'm marking this as no release notes and then I will update #3824 notes to include changes from this so that the release notes for this change are still in a single bullet.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • API modification

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

* Apply some suggestions from post-merge code review
* Add "use" to CLI option: --use-legacy-shift-right-width
* Improve stability of emitted FIRRTL and Verilog when using legacy
  option
* DRY out the tests
@jackkoenig jackkoenig added the No Release Notes Exclude from release notes, consider using Internal instead label Feb 20, 2024
@jackkoenig jackkoenig merged commit ff3766b into main Feb 20, 2024
17 checks passed
@jackkoenig jackkoenig deleted the shr-right-width-change-part-2 branch February 20, 2024 23:59
@jackkoenig jackkoenig added this to the 7.0 milestone Feb 20, 2024
sequencer pushed a commit that referenced this pull request Feb 28, 2024
* Apply some suggestions from post-merge code review
* Add "use" to CLI option: --use-legacy-shift-right-width
* Improve stability of emitted FIRRTL and Verilog when using legacy
  option
* DRY out the tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Release Notes Exclude from release notes, consider using Internal instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants