Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Typo in ExtractFromVecSizeZero warning message #4029

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Fix Typo in ExtractFromVecSizeZero warning message #4029

merged 1 commit into from
Apr 25, 2024

Conversation

jerryz123
Copy link
Contributor

@jerryz123 jerryz123 commented Apr 25, 2024 •
edited
Loading

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Typo

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).
  • Rebase: You will rebase the PR onto master and it will be merged with a merge commit.

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig
Copy link
Contributor

@jerryz123 there's a test checking for that incorrect message 😂, please update it as well chiselTests.stage.WarningConfigurationSpec.

@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label Apr 25, 2024
@jackkoenig jackkoenig added this to the 5.x milestone Apr 25, 2024
@jackkoenig jackkoenig mentioned this pull request Apr 25, 2024
Open
21 tasks
@jackkoenig jackkoenig merged commit 1e0a9e9 into chipsalliance:main Apr 25, 2024
15 checks passed
@mergify mergify bot added the Backported This PR has been backported label Apr 25, 2024
mergify bot pushed a commit that referenced this pull request Apr 25, 2024
@jerryz123 @mergify
Fix Typo in ExtractFromVecSizeZero warning message (#4029)
2011ff9 
(cherry picked from commit 1e0a9e9)

# Conflicts:
#	core/src/main/scala/chisel3/Aggregate.scala
#	src/test/scala/chiselTests/stage/WarningConfigurationSpec.scala
@mergify mergify bot mentioned this pull request Apr 25, 2024
Closed
28 tasks
mergify bot pushed a commit that referenced this pull request Apr 25, 2024
@jerryz123 @mergify
Fix Typo in ExtractFromVecSizeZero warning message (#4029)
5c50429 
(cherry picked from commit 1e0a9e9)
@mergify mergify bot mentioned this pull request Apr 25, 2024
Merged
14 tasks
chiselbot pushed a commit that referenced this pull request Apr 25, 2024
@mergify @jerryz123
Fix Typo in ExtractFromVecSizeZero warning message (#4029) (#4031)
3166d5a 
(cherry picked from commit 1e0a9e9)

Co-authored-by: Jerry Zhao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Milestone
5.x
Development

Successfully merging this pull request may close these issues.
2 participants
@jerryz123 @jackkoenig