-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add modulePorts and fullModulePorts in DataMirror for Instance #4076
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but please see comments on tests.
Also this is failing to generate ScalaDoc due to ambiguous links. Theoretically it's possible to disambiguate them but I find ScalaDoc to be super flakey on that so just replace the [[
and ]]
around [[DataMirror.modulePorts]]
with backticks
and call it a day. You can reproduce the failure with sbt "unipublish / unidoc"
(cherry picked from commit 62bbad5) # Conflicts: # core/src/main/scala/chisel3/reflect/DataMirror.scala # src/test/scala/chiselTests/reflect/DataMirrorSpec.scala
…ort #4076) (#4077) * Add modulePorts and fullModulePorts in DataMirror for Instance (#4076) (cherry picked from commit 62bbad5) # Conflicts: # core/src/main/scala/chisel3/reflect/DataMirror.scala # src/test/scala/chiselTests/reflect/DataMirrorSpec.scala * Resolve backport conflicts --------- Co-authored-by: Deborah Soung <[email protected]> Co-authored-by: Jack Koenig <[email protected]>
Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
Added
modulePorts
andfullModulePorts
methods inDataMirror
that returns all ports on anInstance
of a module.Reviewer Checklist (only modified by reviewer)
3.6.x
,5.x
, or6.x
depending on impact, API modification or big change:7.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.