-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix boring tap of non-passive source from parent. (backport #4083) #4096
Conversation
Cherry-pick of 0dbedc3 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Expected result is fully aligned, which is what happens when reading from a probe. When the source is already at the LCA (from parent) there's no probe and the secret connections only support a few commands. For lack of a way to do, e.g., `:#=` here, use `read(probe(x))` to get the fully aligned result that's expected and bored down to the child. This isn't ideal but fixes this using only the sorts of expressions and commands that we've already committed to supporting. Fixes #3557. (cherry picked from commit 0dbedc3) # Conflicts: # core/src/main/scala/chisel3/RawModule.scala
dd8987a
to
9f8287a
Compare
I intentionally rebased this on top of 1 commit older of 6.x (i.e. not tip of 6.x) because I'm trying to trigger the issue where Mergify will attempt to update the branch by merging |
/easycla |
Expected result is fully aligned, which is what happens when reading from a probe.
When the source is already at the LCA (from parent) there's no probe and the secret connections only support a few commands.
For lack of a way to do, e.g.,
:#=
here,use
read(probe(x))
to get the fully aligned result that's expected and bored down to the child.This isn't ideal but fixes this using only the sorts of expressions and commands that we've already committed to supporting.
Fixes #3557.
Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
Fix tapping mix-alignment signal from parent.
Reviewer Checklist (only modified by reviewer)
3.6.x
,5.x
, or6.x
depending on impact, API modification or big change:7.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.This is an automatic backport of pull request #4083 done by [Mergify](https://mergify.com).