Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve UInt and SInt literals across .pad #4156

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Preserve UInt and SInt literals across .pad #4156

merged 1 commit into from
Jun 7, 2024

Conversation

jackkoenig
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Feature New feature, will be included in release notes label Jun 7, 2024
@jackkoenig jackkoenig added this to the 6.x milestone Jun 7, 2024
@jackkoenig jackkoenig requested a review from mwachs5 June 7, 2024 21:28
@jackkoenig jackkoenig force-pushed the pad-preserve-literal branch from e6ffffe to 97c7dbd Compare June 7, 2024 21:47
@jackkoenig jackkoenig merged commit 65a05b2 into main Jun 7, 2024
15 checks passed
@jackkoenig jackkoenig deleted the pad-preserve-literal branch June 7, 2024 22:45
@mergify mergify bot added the Backported This PR has been backported label Jun 7, 2024
mergify bot pushed a commit that referenced this pull request Jun 7, 2024
@jackkoenig @mergify
Preserve UInt and SInt literals across .pad (#4156)
b1a21b3 
(cherry picked from commit 65a05b2)
@mergify mergify bot mentioned this pull request Jun 7, 2024
Merged
14 tasks
chiselbot pushed a commit that referenced this pull request Jun 7, 2024
@mergify @jackkoenig
Preserve UInt and SInt literals across .pad (backport #4156) (#4157)
505ce19 
* Preserve UInt and SInt literals across .pad (#4156)

(cherry picked from commit 65a05b2)

* Waive false binary compatibility issue

---------

Co-authored-by: Jack Koenig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwachs5 mwachs5 mwachs5 approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Feature New feature, will be included in release notes
Projects
None yet
Milestone
6.x
Development

Successfully merging this pull request may close these issues.
2 participants
@jackkoenig @mwachs5