Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.6.x] Modernize Release Flow #4213

Merged
merged 14 commits into from
Jun 24, 2024

Conversation

jackkoenig
Copy link
Contributor

@jackkoenig jackkoenig commented Jun 24, 2024

I did this quickly and a little bit slash-and-burn-y, but @jerryz123 requested 3.6.1 to help Chipyard. The legacy release flow is too much work to maintain so I went ahead and applied the same modernizations to 3.6.x that we did in 5.x. Once merged, a 3.6.0+50- will be published and Jerry can test with it, if it works, we can publish 3.6.1 from this repo rather than the legacy flow.

Note this must be merged with a merge commit as it is intentionally merging in the commit history from 3.6-release which contains the actual commit tagged v3.6.0 which is needed for ci-release to work properly.

  • Pin firrtl version to 1.6.0
  • Pin chiseltest version used in testing to 0.6.2
  • Switch to unipublish
  • Remove 3.6.0 as MiMa previous version as unipublish won't work with it
    Will restore checks with 3.6.1 release, this is mitigated by the fact
    that every backport to this point has been checked.
  • Update Github Actions versions
  • Remove CI for documentation and website (handled by main branch)

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

  • Rebase: You will rebase the PR onto master and it will be merged with a merge commit.

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Internal Internal change, does not affect users, will be included in release notes label Jun 24, 2024
* Pin firrtl version to 1.6.0
* Pin chiseltest version used in testing to 0.6.2
* Switch to unipublish
* Remove 3.6.0 as MiMa previous version as unipublish won't work with it
  Will restore checks with 3.6.1 release, this is mitigated by the fact
  that every backport to this point has been checked.
* Update Github Actions versions
* Remove CI for documentation and website (handled by main branch)
@jackkoenig jackkoenig force-pushed the jackkoenig/3.6.x/modernize-release-flow branch from de03fdc to f837869 Compare June 24, 2024 19:08
@jackkoenig jackkoenig merged commit fc5bae9 into 3.6.x Jun 24, 2024
12 checks passed
@jackkoenig jackkoenig deleted the jackkoenig/3.6.x/modernize-release-flow branch June 24, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Internal change, does not affect users, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant