-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.6.x] Modernize Release Flow #4213
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….x/modernize-release-flow But ignore changes for 3.6-release. This is just to get the 3.6.0 tag in the commit history.
* Pin firrtl version to 1.6.0 * Pin chiseltest version used in testing to 0.6.2 * Switch to unipublish * Remove 3.6.0 as MiMa previous version as unipublish won't work with it Will restore checks with 3.6.1 release, this is mitigated by the fact that every backport to this point has been checked. * Update Github Actions versions * Remove CI for documentation and website (handled by main branch)
de03fdc
to
f837869
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did this quickly and a little bit slash-and-burn-y, but @jerryz123 requested 3.6.1 to help Chipyard. The legacy release flow is too much work to maintain so I went ahead and applied the same modernizations to 3.6.x that we did in 5.x. Once merged, a 3.6.0+50- will be published and Jerry can test with it, if it works, we can publish 3.6.1 from this repo rather than the legacy flow.
Note this must be merged with a merge commit as it is intentionally merging in the commit history from
3.6-release
which contains the actual commit taggedv3.6.0
which is needed for ci-release to work properly.Will restore checks with 3.6.1 release, this is mitigated by the fact
that every backport to this point has been checked.
Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.6.x
,5.x
, or6.x
depending on impact, API modification or big change:7.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.