Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine annotate and Targetable (backport #4698) #4703

Open
wants to merge 1 commit into
base: 6.x
Choose a base branch
from

Conversation

chiselbot
Copy link
Collaborator

Some minor improvements to the user API for annotating with Targetable

  • Support annotating Seq[Targetable] and provide Targetable for AnyTargetable.
  • Add AnyTargetable.apply for simpler manual conversions.
  • Show tests annotating Seq[Targetable] and manual use of AnyTargetable.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • No Release Notes

Changes to unreleased API

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

This is an automatic backport of pull request #4698 done by [Mergify](https://mergify.com).

Some minor improvements to the user API for annotating with Targetable
* Support annotating Seq[Targetable] and provide Targetable for AnyTargetable.
* Add AnyTargetable.apply for simpler manual conversions.
* Show tests annotating Seq[Targetable] and manual use of AnyTargetable.

(cherry picked from commit e20069e)
@mergify mergify bot added the Backport Automated backport, please consider for minor release label Feb 18, 2025
@mergify mergify bot mentioned this pull request Feb 18, 2025
14 tasks
@github-actions github-actions bot added the No Release Notes Exclude from release notes, consider using Internal instead label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Automated backport, please consider for minor release No Release Notes Exclude from release notes, consider using Internal instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants