Fixed point width inference was wrong when binary points didn't align. #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chick
approved these changes
Apr 25, 2017
edwardcwang
force-pushed
the
fix_fp_width_infer
branch
from
ad65319 to
e9b5f90
Compare
|
retest this please |
|
@ucbjrl can I merge this now? |
edwardcwang
force-pushed
the
fix_fp_width_infer
branch
from
a1759a9 to
cc69a72
Compare
|
Be my guest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chick I'm not sure how this escaped some of the mixed width/binary point tests... Basically, if I was subtracting a <<9>><<0>> number from a <<22>><<21>> number, the immediate output was right... but when the output was passed through subsequent ops, getWidth was wrong (therefore cloneType was wrong... and everything after that was wrong).