AmbaProt memory type for non-cacheable fetches should be "Normal Non-cacheable Bufferable" #2928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingallsj
force-pushed
the
icache-amba-alloc
branch
from
fda7c77 to
0666b39
Compare
hcook
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: follow-up to #2386
Type of change: bug report
Impact: functional change
Development Phase: implementation
Release Notes
We don't believe anything inside Rocket-chip was depending on this.
If somebody was using the Cacheable bit from a Non-cacheable AXI or AHB port, then this would be an errata.
The AMBA AXI protocol specification includes a section “Mismatched memory attributes” which says: