Always pass -xc++: Tell the compiler the language to compile
#2104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bazel just invokes the compiler (gcc or clang) in its basic form and expects it to figure out if the language is C or C++. Make sure it always is told that it is C++; not all compiler installatins are set-up to auto-detect (looking at you, clang-installation-on-NixOS...). Works around Issue NixOS/nixpkgs#216047 Issue NixOS/nixpkgs#150655
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2104 +/- ##
=======================================
Coverage 92.91% 92.91%
=======================================
Files 358 358
Lines 26572 26572
=======================================
Hits 24689 24689
Misses 1883 1883 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel just invokes the compiler (gcc or clang) in its basic form and expects it to figure out if the language is C or C++.
Make sure it always is told that it is C++; not all compiler installatins are set-up to auto-detect (looking at you, clang-installation-on-NixOS...).
Works around
Issue NixOS/nixpkgs#216047
Issue NixOS/nixpkgs#150655