Use app_data_dir to detect gms and fix refine code* #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly detect gms process
Use app_data_dir to detect gms Refine code
Use: std::string_view(app_data_dir).ends_with Thanks for the suggestion: 钱钱 (Telegram ID: 259634215)
|
How is he supposed to check when you've made so many changes that it's almost unreadable? I do agree much of the formatting needs fixing here, but that should be a separate change in a separate PR. |
I assume he understands since it was discussed on the Telegram channel, but it is already clear that these changes are for the better. Also, it is sufficient to look at only 1-4 commits is enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@HuskyDG check.
It makes more sense based on my tests (perf and gms reading)