Manual cherry-pick to avoid conflict with step-params

Fix: Identify workspace usage in a Task

Prior to this, when identifying whether a Task used a workspace,
we limited the check to command, args and scripts in steps,
stepTemplates and sidecars. However, the workspace path could also
be used as a param to a StepAction or env cariables in steps and
sidecars and also workingDirs. This PR fixes that.

Fixes tektoncd#8008.

pkg/workspace/apply.go

@@ -250,13 +250,6 @@ func findWorkspaceSubstitutionLocationsInSteps(steps []v1.Step) sets.String {
 		for _, e := range step.Env {
 			locationsToCheck.Insert(e.Value)
 		}
-		for _, p := range step.Params {
-			locationsToCheck.Insert(p.Value.ArrayVal...)
-			for k := range p.Value.ObjectVal {
-				locationsToCheck.Insert(p.Value.ObjectVal[k])
-			}
-			locationsToCheck.Insert(p.Value.StringVal)
-		}
 	}
 	return locationsToCheck
 }

pkg/workspace/apply_test.go

@@ -1254,23 +1254,6 @@ func TestFindWorkspacesUsedByTask(t *testing.T) {
 		want: sets.NewString(
 			"shared",
 		),
-	}, {
-		name: "workspace used in step Params for stepactions",
-		ts: &v1.TaskSpec{
-			Steps: []v1.Step{{
-				Name: "step-name",
-				Params: []v1.Param{{
-					Name:  "path",
-					Value: *v1.NewStructuredValues("$(workspaces.shared.path)"),
-				}},
-				Ref: &v1.Ref{
-					Name: "step-action",
-				},
-			}},
-		},
-		want: sets.NewString(
-			"shared",
-		),
 	}, {
 		name: "workspace used in sidecar env",
 		ts: &v1.TaskSpec{