Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-133) Update config.pp to accomodate new choco feature list -r output #132

Closed
wants to merge 1 commit into from

Conversation

nicolasvan
Copy link
Contributor

@nicolasvan nicolasvan commented Jun 20, 2016

The findstr fails to match on the new versions of chocolatey 0.9.10+.

With this change, It can now match

  • autoUninstaller|Enabled| for choco 0.9.10+
  • autoUninstaller - [Enabled] for choco 0.9.9

Closes #133

The findstr fails to match on the new version of chocolatey 0.9.10.2.
It can now find: "autoUninstaller|Enabled|" or "autoUninstaller|Disabled|"
@ferventcoder
Copy link
Contributor

@nicolasvan looks good - can you address the CI failure?

@ferventcoder
Copy link
Contributor

Nevermind, looks like an external issue. I rekicked it off.

@ferventcoder
Copy link
Contributor

This is the issue we are seeing - https://tickets.puppetlabs.com/browse/FORGE-327

@ferventcoder
Copy link
Contributor

ferventcoder commented Jun 20, 2016

Fixed up commit message as 17939c6 and merged into master at 84786e2. Thanks!

@ferventcoder ferventcoder changed the title Update config.pp to accomodate new choco feature list -r output (GH-133) Update config.pp to accomodate new choco feature list -r output Jun 20, 2016
DavidS pushed a commit to DavidS/puppetlabs-chocolatey that referenced this pull request Nov 15, 2019
…t/master/MODULES-4418

(MODULES-4418) Add bypass_proxy to chocolateysource
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants