fix chocolatey latest logic #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rismoney
force-pushed
the
fix_latest
branch
2 times, most recently
from
51d3028 to
9d7ab6e
Compare
|
@ferventcoder - while the rspec passes now, i don't think i've got it right. can you take a gander when you get a moment? perhaps your puppet/ruby expertise can shed light on this. |
rismoney
force-pushed
the
fix_latest
branch
2 times, most recently
from
eed7d7a to
e01ad13
Compare
|
think i got it right now. gonna merge soon. |
The current chocolatey-update behavior states that if a package is not installed, then chocolatey returns "nothing to update" This commit, adjusts the ensure=>latest logic: specifically Case: Package is not installed Action: Provider will perform a chocolatey install Result: the latest package installed Case: Package is installed but oldIf Action: Provider will run chocolatey update to the latest version Result: the latest package installed Case: Package is already on the latest version Action: Provider will not do anything. Result: the latest packaged installed This also clarified variable name from latest method packages is really package_ver Fix issue with travis.yml to provide language
rismoney
force-pushed
the
fix_latest
branch
from
e01ad13 to
efdf354
Compare
Closed
|
Was this merged in? :) |
|
Does appear that it was merged in. I don't see it contained in any tags or branches. |
ferventcoder
pushed a commit
to ferventcoder/puppet-chocolatey
that referenced
this pull request
Aug 29, 2016
(docs) Update README to current module readme style guidelines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current chocolatey-update behavior states that if a package
is not installed, then chocolatey returns "nothing to update"
This commit, adjusts the ensure=>latest logic: specifically
Case: Package is not installed
Action: Provider will perform a chocolatey install
Result: the latest package installed
Case: Package is installed but oldIf
Action: Provider will run chocolatey update to the latest version
Result: the latest package installed
Case: Package is already on the latest version
Action: Provider will not do anything.
Result: the latest packaged installed
This also clarified variable name from latest method
packages is really package_ver