Core extension #390
Core extension #390
Conversation
|
|
||
| Write-Verbose "Trying local and machine (x32 & x64) Uninstall keys" | ||
| [array] $key = Get-UninstallRegistryKey $AppNamePattern | ||
| if ($key.Count -eq 1) { |
There was a problem hiding this comment.
Couldn't this possibly cause a problem?
Let's say that the Get-UninstallRegistryKey finds two keys with the same name, which points to
lets say the exact same path.
Personally I think that should be handled correctly, for instance by allowing a user
to override the exact count expected?
There was a problem hiding this comment.
@AdmiringWorm that sounds like a good idea to me. I haven't pushed the core-extension yet, so there is still time to fix this (if required) before it is pushed.
There was a problem hiding this comment.
@majkinetor what are your thoughts?
There was a problem hiding this comment.
How it could cause a problem ? If there are two keys, it will just skip this entire section. I could select -first 1 also but the point of the function was to require no special input.
What I did it in the past is change it as soon as some package appears that it can't find but could actually find it with minor modifications.
So lets keep it like this now, its already quite tested, and will see in the future when problem arises.
|
BTW, Uninstall-ChocolateyPath (chocolatey/choco#310) is something that naturally belongs here. EDIT Or maybe not, I didn't know there is so much activity about it recently. It will prolly get soon included among helpers. |
|
I fixed one small error. It should be good to push now I believe. |
Yes, I believe that we should wait before doing anything in this area. |
No description provided.