Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chocolatey GUI doesn't write to chocolatey.log #697

Closed
jacktose opened this issue Oct 2, 2019 · 2 comments · Fixed by #861
Closed

Chocolatey GUI doesn't write to chocolatey.log #697

jacktose opened this issue Oct 2, 2019 · 2 comments · Fixed by #861
Labels
5 - Released The issue has been resolved, and released to the public for consumption Improvement Issues that enhances existing functionality, or adds new features
Milestone
0.20.0

Comments

@jacktose
Copy link

jacktose commented Oct 2, 2019

Chocolatey CLI writes to C:\ProgramData\chocolatey\logs\chocolatey.log, but Chocolatey GUI does not.

This is especially confusing because the CLI output that the GUI shows says to look in the chocolatey log: image

@gep13 says it's a known issue:

This is a side effect of the way that Chocolatey GUI calls into Chocolatey. We pass in an additional logger which should mean that logging happens to both the chocolatey log and the chocolatey gui log.

Possibly related to #695.
@ferventcoder
Copy link
Member

chocolatey/choco#2122

@ferventcoder ferventcoder added :Chocolatey Blocked - External The issue or pull request is not fixable without a change in a upstream/external library Improvement Issues that enhances existing functionality, or adds new features labels Sep 25, 2020
AdmiringWorm added a commit to AdmiringWorm/ChocolateyGUI that referenced this issue Jun 21, 2021
@AdmiringWorm
(chocolatey#697) Update Chocolatey API calling
337b9a7 
This commit makes changes to how the Chocolatey API is being called,
which then allows the original logging that Chocolatey implements
to still happen when we add our own Serilog logger.

This change depends on a new change in the Chocolatey codebase,
and a new release of the program.
@AdmiringWorm AdmiringWorm mentioned this issue Jun 21, 2021
Merged
AdmiringWorm added a commit to AdmiringWorm/ChocolateyGUI that referenced this issue Jun 23, 2021
@AdmiringWorm
(chocolatey#697) Update Chocolatey API calling
59e7b6e 
This commit makes changes to how the Chocolatey API is being called,
which then allows the original logging that Chocolatey implements
to still happen when we add our own Serilog logger.

This change depends on a new change in the Chocolatey codebase,
and a new release of the program.
AdmiringWorm added a commit to AdmiringWorm/ChocolateyGUI that referenced this issue Jan 21, 2022
@AdmiringWorm
(chocolatey#697) Update Chocolatey API calling
cede63c 
This commit makes changes to how the Chocolatey API is being called,
which then allows the original logging that Chocolatey implements
to still happen when we add our own Serilog logger.

This change depends on a new change in the Chocolatey codebase,
and a new release of the program.
@AdmiringWorm AdmiringWorm added this to the 0.20.0 milestone Jan 25, 2022
AdmiringWorm added a commit to AdmiringWorm/ChocolateyGUI that referenced this issue Jan 27, 2022
@AdmiringWorm
(chocolatey#697) Update Chocolatey API calling
2b686b8 
This commit makes changes to how the Chocolatey API is being called,
which then allows the original logging that Chocolatey implements
to still happen when we add our own Serilog logger.

This change depends on a new change in the Chocolatey codebase,
and a new release of the program.
@AdmiringWorm AdmiringWorm added the 3 - Review Code has been added, and is available for review as a pull request label Jan 27, 2022
gep13 added a commit that referenced this issue Jan 27, 2022
@gep13
Merge pull request #861 from AdmiringWorm/new-api-logging
5d1ee07 
(#697) Update Chocolatey API calling
@AdmiringWorm AdmiringWorm added 4 - Done Code has been added to the repository, and has been reviewed by a team member and removed 3 - Review Code has been added, and is available for review as a pull request labels Jan 27, 2022
@gep13 gep13 removed :Chocolatey Blocked - External The issue or pull request is not fixable without a change in a upstream/external library labels Feb 9, 2022
@gep13
Copy link
Member

gep13 commented Feb 10, 2022

🎉 This issue has been resolved in version 0.20.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

@corbob corbob added 5 - Released The issue has been resolved, and released to the public for consumption and removed 4 - Done Code has been added to the repository, and has been reviewed by a team member labels Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
5 - Released The issue has been resolved, and released to the public for consumption Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Milestone
0.20.0
Development

Successfully merging a pull request may close this issue.

(#697) Update Chocolatey API calling AdmiringWorm/ChocolateyGUI
5 participants
@ferventcoder @gep13 @AdmiringWorm @jacktose @corbob