Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve how package icons with an svg extension are rendered #756

Closed
gep13 opened this issue Apr 8, 2020 · 1 comment · Fixed by #759
Closed

Improve how package icons with an svg extension are rendered #756

gep13 opened this issue Apr 8, 2020 · 1 comment · Fixed by #759
Assignees
@punker76
Labels
Improvement Issues that enhances existing functionality, or adds new features
Milestone
0.18.0

Comments

@gep13
Copy link
Member

gep13 commented Apr 8, 2020

This is related to this issue: #739

Currently, within Chocolatey GUI, svg icons are not rendering correctly. Take for example the Firefox icon:

image
@gep13 gep13 added the Improvement Issues that enhances existing functionality, or adds new features label Apr 8, 2020
@gep13 gep13 added this to the 0.18.0 milestone Apr 8, 2020
@punker76 punker76 self-assigned this Apr 10, 2020
punker76 added a commit to punker76/ChocolateyGUI that referenced this issue Apr 10, 2020
@punker76
(chocolateyGH-756) Improve Svg icon rendering by using Svg.Skia (Skia…
6ea4785 
…Sharp)
punker76 added a commit to punker76/ChocolateyGUI that referenced this issue Apr 10, 2020
@punker76
(chocolateyGH-756) Fix codacy error
5aa83cb
punker76 added a commit to punker76/ChocolateyGUI that referenced this issue Apr 10, 2020
@punker76
(chocolateyGH-756) Improve Svg icon rendering by using Svg.Skia (Skia…
122cf47 
…Sharp)
punker76 added a commit to punker76/ChocolateyGUI that referenced this issue Apr 10, 2020
@punker76
(chocolateyGH-756) Fix codacy error
3372580
punker76 added a commit to punker76/ChocolateyGUI that referenced this issue Apr 10, 2020
@punker76
(chocolateyGH-756) Load all other icons with SkiaSharp SKBitmap
bf51906
punker76 added a commit to punker76/ChocolateyGUI that referenced this issue Apr 10, 2020
@punker76
(chocolateyGH-756) Remove Magick.NET package
81739e8
@punker76 punker76 mentioned this issue Apr 10, 2020
Merged
2 tasks
punker76 added a commit to punker76/ChocolateyGUI that referenced this issue Apr 10, 2020
@punker76
(chocolateyGH-756) Remove Magick.NET package
c490398 
(chocolateyGH-756) Remove Magick.NET package
gep13 added a commit that referenced this issue Apr 11, 2020
@gep13
Merge pull request #759 from punker76/feature/GH-756
1d87ac2 
(GH-756) Improve Svg icon rendering by using Svg.Skia (SkiaSharp)
@gep13 gep13 changed the title Improve how icons with an svg extension are rendered within Chocolatey GUI Improve how icons with an svg extension are rendered Mar 8, 2021
@gep13 gep13 changed the title Improve how icons with an svg extension are rendered Improve how package icons with an svg extension are rendered Mar 8, 2021
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.18.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@punker76 punker76

Labels
Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Milestone
0.18.0
Development

Successfully merging a pull request may close this issue.

(GH-756) Improve Svg icon rendering by using Svg.Skia (SkiaSharp) punker76/ChocolateyGUI
3 participants
@punker76 @gep13 @choco-bot